Add markdown guide to link a device #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchassoul
requested changes
Feb 23, 2024
LINKING.md
Outdated
There was a problem hiding this comment.
I made a few changes but I think it's too much to add them as separated comments. I'm adding a markdown file so you can review it. (It has the same information but rephrased, I think more user friendly) n.n
GRiSP2_Board_Registration_Guide.md
rebar.config
Outdated
| @@ -35,6 +35,7 @@ | |||
| {extras, [ | |||
| {"CHANGELOG.md", #{title => "Changelog"}}, | |||
| {"README.md", #{title => "Overview"}}, | |||
| {"LINKING.md", #{title => "Device Linking"}}, | |||
There was a problem hiding this comment.
Also, maybe rename LINKING.md or even Device Linking to Board Registration Guide or Device Linking Guide . what do you think?
bchassoul
approved these changes
Feb 23, 2024
bchassoul
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Add markdown guide to link a device * Add guide to ex_doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This guide should be replicated or linked from grisp.io grisp_manager device view.